firmware_uefi: EfiDiagnostics change to tracelimit with custom period and limit #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maheeraeron merged 12 commits into microsoft:main from maheeraeron:user/maheeraeron/efidiagnostics-tracing

Jul 17, 2025

Contributor

maheeraeron commented Jul 15, 2025

This PR focuses on changing all the tracing statements for diagnostics to use tracelimit instead, with custom period and limits. Without the custom configuration, tracelimit will quickly drop EfiDiagnostics logs.


          let tracelimit define custom period and limit

b7e3b4c

maheeraeron changed the title ~~firmware_uefi: EfiDiagnostics change to tracelimit with custom period and limit~~ [WIP] firmware_uefi: EfiDiagnostics change to tracelimit with custom period and limit


          Use new tracelimit with limit

6358f3f

maheeraeron commented

View reviewed changes

vm/devices/firmware/firmware_uefi/src/service/diagnostics.rs Outdated Show resolved Hide resolved

Contributor Author

maheeraeron commented Jul 15, 2025 •

edited

Loading

If anyone is curious what the output looks like between using tracing::*!(), the old tracelimit::*_ratelimited!() and new with configurable period/limit tracelimit::*_ratelimited!():

traceoutput.txt


          Add runtime support for ratelimiting

f9a9c40

maheeraeron marked this pull request as ready for review

July 15, 2025 23:15

maheeraeron requested a review from a team as a code owner

July 15, 2025 23:15

maheeraeron changed the title ~~[WIP] firmware_uefi: EfiDiagnostics change to tracelimit with custom period and limit~~ firmware_uefi: EfiDiagnostics change to tracelimit with custom period and limit

maheeraeron added 2 commits

July 16, 2025 10:44


          Fix lifetime on handle_efi_diagnostics_log

c9cd010


          Merge branch 'main' into user/maheeraeron/efidiagnostics-tracing

chris-oo reviewed

View reviewed changes

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved


          Remove hashmap in rate limiter

bcb95e7

chris-oo reviewed

View reviewed changes

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved

maheeraeron added 3 commits

July 16, 2025 13:50


          Use inner mutex, change state in event_with_config(), additional feed…

9aec5a1

…back


          Merge branch 'main' into user/maheeraeron/efidiagnostics-tracing

de764b9


          Remove unncessary doc hidden

2d26358

chris-oo reviewed

View reviewed changes

support/tracelimit/src/lib.rs Outdated Show resolved Hide resolved

chris-oo reviewed

View reviewed changes

vm/devices/firmware/firmware_uefi/src/service/diagnostics.rs Outdated Show resolved Hide resolved


          Remove shared rate limiter and create a static one for every callsite

aab7e8e

github-actions bot commented Jul 16, 2025

At least one Petri test failed.


          Use only one events_per_period limit value, prevent reprocessing on w…

fdc52da

…atchdog timeout

chris-oo reviewed

View reviewed changes

vm/devices/firmware/firmware_uefi/src/service/diagnostics.rs Outdated Show resolved Hide resolved


          Change context to triggered_by, output it on success

39acd25

chris-oo approved these changes

View reviewed changes

maheeraeron merged commit 7a536e1 into microsoft:main

48 of 50 checks passed

maheeraeron added a commit to maheeraeron/openvmm that referenced this pull request


          firmware_uefi: EfiDiagnostics change to tracelimit with custom period…

732bfff

… and limit (microsoft#1706)

maheeraeron added the backport_2505 label

This was referenced Jul 17, 2025

firmware_uefi: EfiDiagnostics backports for watchdog handling, tracelimit and other improvements #1691

Merged

Improve EfiDiagnostics flush code #1692

Closed

maheeraeron mentioned this pull request

openhcl/firmware_uefi: EfiDiagnostics filter known error messages #1522

Open

maheeraeron added a commit that referenced this pull request


          firmware_uefi: EfiDiagnostics backports for watchdog handling, tracel…

4cd692a

…imit and other improvements (#1691)

This PR backports four PRs on EfiDiagnostics improvements and feature
gaps. The four PRs are here:

1. #1668
2. #1677
3. #1693
4. #1706

maheeraeron deleted the user/maheeraeron/efidiagnostics-tracing branch

July 17, 2025 21:53

Member

benhillis commented Jul 18, 2025

Backported with #1691

benhillis added backported_2505 and removed backport_2505 labels

gurasinghMS pushed a commit to gurasinghMS/openvmm that referenced this pull request


          firmware_uefi: EfiDiagnostics change to tracelimit with custom period…

41de9c0

… and limit (microsoft#1706)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported_2505